Two update-BROWSER suggestions
Posted: 07 Mar 2020, 20:39
A suggestion to the maintainers of the update-BROWSER scripts, e.g. update-palemoon, update-firefox et cetera (including, of course, the update-BROWSER-live script, e.g. update-palemoon-live for update-palemoon. (This here is also a suggestion to improve any update-WHATEVER scripts.)
In the unlikely event that an error occurred while creating the resulting module, I suggest a new parameter besides -h for help and -d for working in $PWD instead of working in /tmp:
E.g. just now, after I ran update-palemoon -d I have these two files in $PWD:
I think it would make more sense to only have this instead in the end:
and when given the -k parameter, this should be the end result:
(Yes, I still have the palemoon-28.8.4.linux-x86_64.tar.xz file since I copied it to another partition while the script was creating the txz and later the xzm, but probably not all users are this quick in a console doing so in the limited time span you have prior the script deleting the original downloaded file )
______________________________________
Only checked update-palemoon on the following:Me thinks, it makes no sense to check something (here: user = root, distro = Porteus, CPU = sse2 compatible) and to download something when the given parameter is, like here, "-h", since the script would abort after the help is displayed anyway.
What the script should do and print back at the user should be more like this:Only when the given parameter is not "-h" and not an invalid parameter which should always trigger a script to abort with an error, only then the script should do the following
______________________________
If the maintainer of update-palemoon and update-palmoon-live is okay with that, I could add the -k option and also alter the order to check for the "-h" parameter first and do checks and downloads after that and give you the diff (aka patch) files for update-palemoon and update-palemoon-live if you want. (Since I am still ill with a Non Corona viral pharyngitis I stay at home as much as I need to fully get completely rid of that pharyngitis, so I have more time coding for Port than I usually would have. I recently told someone who strange it is in the train people moving away from me just because I cough, and he replied with "That's a good thing! More space in the train for us!" LOL, just the kind of humour I like.)
In the unlikely event that an error occurred while creating the resulting module, I suggest a new parameter besides -h for help and -d for working in $PWD instead of working in /tmp:
Code: Select all
-k keep downloaded file, e.g. keep palemoon-VERSION.linux-x86_64.tar.xz
Code: Select all
palemoon-28.8.4-x86_64-1.txz
palemoon-28.8.4-x86_64-1.xzm
Code: Select all
palemoon-28.8.4-x86_64-1.xzm
Code: Select all
palemoon-28.8.4-x86_64-1.xzm
palemoon-28.8.4.linux-x86_64.tar.xz
______________________________________
Only checked update-palemoon on the following:
Code: Select all
# update-palemoon -h
Starting checks ...
[OK] User is root.
[OK] Distro is Porteus
[OK] Processor is sse2 compatible
Downloading live script ...
Downloading: update-palemoon-live DONE
options: -d : do operations in the present directory, instead of /tmp .
-h : show this usage.
What the script should do and print back at the user should be more like this:
Code: Select all
# update-palemoon -h
options: -d : do operations in the present directory, instead of /tmp .
-h : show this usage.
Code: Select all
Starting checks ...
[OK] User is root.
[OK] Distro is Porteus
[OK] Processor is sse2 compatible
Downloading live script ...
Downloading: update-palemoon-live DONE
If the maintainer of update-palemoon and update-palmoon-live is okay with that, I could add the -k option and also alter the order to check for the "-h" parameter first and do checks and downloads after that and give you the diff (aka patch) files for update-palemoon and update-palemoon-live if you want. (Since I am still ill with a Non Corona viral pharyngitis I stay at home as much as I need to fully get completely rid of that pharyngitis, so I have more time coding for Port than I usually would have. I recently told someone who strange it is in the train people moving away from me just because I cough, and he replied with "That's a good thing! More space in the train for us!" LOL, just the kind of humour I like.)