Porteus-v4.0rc4 bug reports

Please reproduce your error on a second machine before posting, and check the error by running without saved changes or extra modules (See FAQ No. 13, "How to report a bug"). For unstable Porteus versions (alpha, beta, rc) please use the relevant thread in our "Development" section.
User avatar
alsass
White ninja
White ninja
Posts: 5
Joined: 01 Apr 2018, 19:09
Distribution: Porteus XFCE V3.2.2 32bit
Location: Europe

Porteus-v4.0rc4 bug reports

Post#106 by alsass » 08 Apr 2018, 15:47

Thanks brokenman. I'll do my best to submit the other patches soon.

Unfortunately I discovered a glitch with one of my patches.
The sourcing of "/tmp/.vbox-live" does not work as intended. My apologies.
Here is a corrected version of the patch:

update-vbox.patch for file /opt/porteus-scripts/update-vbox

Code: Select all

--- update-vbox.orig	2016-05-29 01:46:47.000000000 +0200
+++ update-vbox	2018-04-08 17:31:11.852397783 +0200
@@ -10,7 +10,7 @@
 PIXMAPS=/usr/share/pixmaps/porteus
 SERVER=`awk -F= '/SERVER=/{print$NF}' /etc/porteus.conf`
 link=$SERVER/i586/testing/live/update-vbox-live
-trap cleanup SIGHUP SIGINT SIGTERM
+trap cleanup 0
 
 cleanup(){
 rm /tmp/.vbox-live 2>/dev/null
@@ -49,7 +49,7 @@
 	<hbox>
 		'`txtmarkup 220 "Choose an option: "`'
 		<comboboxtext active="6" focus-on-click="false" button-sensitivity="1">
-			<variable>vbox-live</variable>
+			<variable>vbox_live</variable>
 			<item>VirtualBox</item>
 			<item>VirtualBox Guest additions</item>
 		</comboboxtext>
@@ -64,18 +64,21 @@
 </window>
 '
 gtkdialog -p MAIN_DIALOG > /tmp/.vbox-live
+. /tmp/.vbox-live
 
-[ `egrep "Cancel|abort" /tmp/.vbox-live` ] && { cleanup; exit; }
-[[ `grep vbox-live /tmp/.vbox-live 2>/dev/null|cut -d'"' -f2` == "" ]] &&  { cleanup; exit; }
+if [ "$EXIT" = "abort" -o "$EXIT" = "Cancel" -o "$vbox_live" = "" ]; then
+   exit
+fi
 
-answer=`awk -F'"' '/vbox-live/{print$2}' /tmp/.vbox-live`
+answer=$vbox_live
 ## Internet check
 if [ ! -e /tmp/update-vbox-live ]; then
 if wget --spider -v "$link"; then
+        export HAS_NO_INTERNET=0
 	wget $link -P /tmp
 		else
+        export HAS_NO_INTERNET=1
 	gtk_message "An internet connection was not found or the porteus server was not reachable. Exiting now." 450 gtk-dialog-warning
-	cleanup
 fi
 fi
 
@@ -85,12 +88,8 @@
 case $answer in
 VirtualBox )
 /usr/local/bin/update-vbox-live vbox
-cleanup
 ;;
 "VirtualBox Guest additions" )
 /usr/local/bin/update-vbox-live vboxguest
-cleanup
 ;;
 esac
-
-rm /tmp/.vbox-live 2>/dev/null
This patch should be applied to the original version of the file.
Sorry for the trouble.

Thanks
hoppla geiss!

User avatar
alsass
White ninja
White ninja
Posts: 5
Joined: 01 Apr 2018, 19:09
Distribution: Porteus XFCE V3.2.2 32bit
Location: Europe

Porteus-v4.0rc4 bug reports

Post#107 by alsass » 09 Apr 2018, 15:30

please find the next and last patch below:

this one is for file : /opt/porteus-scripts/xpns-tool

Code: Select all

--- xpns-tool.orig	2012-06-21 22:51:59.000000000 +0000
+++ xpns-tool	2018-04-09 15:18:56.821933178 +0000
@@ -520,7 +520,7 @@
 
 ## Check for good connection
 if [ "$METHOD" == "wifi" -o "$METHOD" == "wired" ]; then 
-  if (wget -q --spider --force-html --inet4-only http://www.google.com >/dev/null 2>&1); then
+  if (wget -q --spider --force-html --inet4-only http://dl.porteus.org >/dev/null 2>&1); then
     connected=1
 	else
     unset connected
The other update-* scripts are already in good shape (for the 40rcX series).

Thanks.
hoppla geiss!

User avatar
Rava
Contributor
Contributor
Posts: 2480
Joined: 11 Jan 2011, 02:46
Distribution: Porteus 5.0rc1 x86-64 XFCe
Location: Forests of Germany

Porteus-v4.0rc4 bug reports

Post#108 by Rava » 20 Jul 2018, 20:19

alsass wrote:
09 Apr 2018, 15:30
please find the next and last patch below:

this one is for file : /opt/porteus-scripts/xpns-tool
Could that even solve my online issue? I think not, it might only apply to update scripts, right, not to the whole system…
Last edited by Rava on 20 Jul 2018, 20:20, edited 1 time in total.
Reason:
Cheers!
Yours Rava

Post Reply